feat(@schematics/angular): add migrate-karma-to-vitest update migration#32936
Open
clydin wants to merge 1 commit intoangular:mainfrom
Open
feat(@schematics/angular): add migrate-karma-to-vitest update migration#32936clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
angular-robot
bot
added
detected: feature
clydin
force-pushed
the
vitest/karma-migration
branch
6 times, most recently
from
0e6efbc to
9d71be1
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new schematic to migrate Angular projects from the legacy Karma unit-test builder to the new Vitest-based unit-test builder. The changes include logic to map Karma configurations, coverage settings, and build options to the new builder, along with necessary dependency updates. Feedback was provided regarding potential configuration overwrites when processing build options, the risk of duplicate entries in the setupFiles array, and the recommendation to use node:util's isDeepStrictEqual instead of JSON.stringify for robust object comparison.
packages/schematics/angular/migrations/migrate-karma-to-vitest/migration.ts
Outdated
Show resolved
Hide resolved
packages/schematics/angular/migrations/migrate-karma-to-vitest/migration.ts
Outdated
Show resolved
Hide resolved
packages/schematics/angular/migrations/migrate-karma-to-vitest/migration.ts
Outdated
Show resolved
Hide resolved
clydin
force-pushed
the
vitest/karma-migration
branch
2 times, most recently
from
226857b to
1078570
Compare
Migrate projects using the Karma unit-test builder to the new @angular/build:unit-test builder with Vitest. This migration automatically updates target builders, translates builder options (such as coverage and browsers format), moves custom build options to dedicated configurations to prevent loss of custom settings, cleans up default configuration files, and installs required Vitest runner packages.
clydin
force-pushed
the
vitest/karma-migration
branch
from
1078570 to
4dbaed6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate projects using the Karma unit-test builder to the new @angular/build:unit-test builder with Vitest.
This migration automatically updates target builders, translates builder options (such as coverage and browsers format), moves custom build options to dedicated configurations to prevent loss of custom settings, cleans up default configuration files, and installs required Vitest runner packages.